techcrunch.git

@@ -33,7 +33,7 @@ def unique(seq, idfun=None):

     return result

-def Process_comments_for_feed(yaml_items):

+def process_comments_for_feed(yaml_items):

     time_blocks = [[], [], [], [], [], [], [], []]

     for i in yaml_items:

         time_posted = i['orig_posted']

@@ -55,7 +55,7 @@ def Process_comments_for_feed(yaml_items):

     return stats

-def Remove_outliers(time_blocks):

+def remove_outliers(time_blocks):

     """remove 6% of the values as outliers (3% from each side)."""

     for block in time_blocks:

         pairs_to_remove = 0

@@ -70,7 +70,7 @@ def Remove_outliers(time_blocks):

             pairs_to_remove -= 1

-def Calculate_median_mean_stddev(time_blocks):

+def calculate_median_mean_stddev(time_blocks):

     stats = []

     for block in time_blocks:

         # Calculate the median

@@ -94,7 +94,7 @@ def Calculate_median_mean_stddev(time_blocks):

     return stats

-def Process_feed(yaml_items, metric, metric_times):

+def process_feed(yaml_items, metric, metric_times):

     weekend_time_blocks = [[], [], [], [], [], [], [], []]

     weekday_time_blocks = [[], [], [], [], [], [], [], []]

     for i in yaml_items:

@@ -111,11 +111,11 @@ def Process_feed(yaml_items, metric, metric_times):

             else:

                 bisect.insort(weekday_time_blocks[value_times_indices[j]], values[j])

-    Remove_outliers(weekend_time_blocks)

-    Remove_outliers(weekday_time_blocks)

+    remove_outliers(weekend_time_blocks)

+    remove_outliers(weekday_time_blocks)

-    weekend_stats = Calculate_median_mean_stddev(weekend_time_blocks)

-    weekday_stats = Calculate_median_mean_stddev(weekday_time_blocks)

+    weekend_stats = calculate_median_mean_stddev(weekend_time_blocks)

+    weekday_stats = calculate_median_mean_stddev(weekday_time_blocks)

     return weekend_stats, weekday_stats

@@ -31,7 +31,7 @@ import smtp_creds  # Your own credentials, used in send_email()

 debug = True

 any_entry_added = False

-tags_to_post = set(['apple', 'google'])

+tags_to_post = {'apple', 'google'}

 authors_to_post = ['michael arrington',]

 # TODO 2018-01-18: Maybe combine fb_likes with bf_shares or something...

@@ -92,9 +92,9 @@ odd_watermark = "D0D0F0"

 def asciiize(s):

     try:

         return s.encode('ascii')

-    except UnicodeEncodeError as e:

+    except UnicodeEncodeError:

         return s

-    except exceptions.AttributeError as e:

+    except exceptions.AttributeError:

         return s

@@ -103,8 +103,8 @@ def send_email(subject, message, toaddrs,

     """ Sends Email """

     smtp = smtplib.SMTP(smtp_creds.server, port=smtp_creds.port)

     smtp.login(smtp_creds.user, smtp_creds.passw)

-    smtp.sendmail(fromaddr, \

-                  toaddrs, \

+    smtp.sendmail(fromaddr,

+                  toaddrs,

                   "Content-Type: text/plain; charset=\"us-ascii\"\r\nFrom: %s\r\nTo: %s\r\nSubject: %s\r\n%s" % \

                   (fromaddr, ", ".join(toaddrs), subject, message))

     smtp.quit()

@@ -134,13 +134,9 @@ def make_chart_url(time_posted, lhs_times, lhs_values, rhs_times,

     lhs_times = [(i - time_posted) / 1800 for i in lhs_times]

     rhs_times = [(i - time_posted) / 1800 for i in rhs_times]

-    min_comment_time = min(lhs_times)

     max_comment_time = max(lhs_times)

-    min_comment_value = min(lhs_values)

     max_comment_value = max(lhs_values)

-    min_rhs_time = min(rhs_times)

     max_rhs_time = max(rhs_times)

-    min_rhs_value = min(rhs_values)

     max_rhs_value = max(rhs_values)

     met_threshold_pt = -1

@@ -213,7 +209,6 @@ def process_feed(yaml_items):

         if feed.status == 304:

             pass

         else:

-            feed_is_modified = True

             if feed.status != 200 and feed.status != 307 and feed.status != 301 and feed.status != 302:

                 if feed.status == 503:

                     print "the feed is temporarily unavailable."

@@ -242,7 +237,6 @@ def process_feed(yaml_items):

                               (# str(e.__class__),

                                str(e))

                         traceback.print_exc(3, file=sys.stdout)

-                        feed_is_modified = False

             for i in reversed(feed.entries):

                 process_item(i, yaml_items)

@@ -295,10 +289,8 @@ def process_item(feed_item, yaml_items):

     date_parsed = time.gmtime()

     if hasattr(feed_item, 'issued_parsed'):

         date_parsed = feed_item.issued_parsed

-        date_set = True

     elif hasattr(feed_item, 'date_parsed'):

         date_parsed = feed_item.date_parsed

-        date_set = True

     else:

         print "process_item found no timestamp for", asciiize(feed_item.link)

     timecode_parsed = calendar.timegm(date_parsed)

@@ -376,14 +368,14 @@ def process_yaml_item(yaml_item):

             yaml_item['fb_likes'].append(num_likes)

 #    if len(yaml_item['reddit_']) < 8:

-#        num_ = Get_reddit_stats(link)

+#        num_ = get_reddit_stats(link)

 #        if num_ != -1:

 #            any_entry_added = True

 #            yaml_item['reddit_times'].append(timecode_now)

 #            yaml_item['reddit_'].append(num_)

-def Get_reddit_stats(url_string):

+def get_reddit_stats(url_string):

     """ Consider curl "https://www.reddit.com/api/info.json?url=http://i.imgur.com/HG9dJ.jpg"

     """

     return -1

@@ -414,15 +406,6 @@ def Get_fb_stats(url_string):

         else:

             print "Get_fb_stats got an error (3):", str(e)

         return shares, comments, likes

-    except KeyError as e:

-        print "Get_fb_stats got a key error 1e (%s)" % (str(e), )

-        print "Get_fb_stats got a key error 2.2 enc (%s)" % (encoded, )

-        print url_string.encode('utf-8')

-        print u"Get_fb_stats got a key error 2.1 url (%s)" % (url_string, )

-        print "Get_fb_stats got a key error 3q (%s)" % (urllib.quote_plus(url_string))

-        print "Get_fb_stats got a key error 4 (%s)" % (url % (urllib.quote_plus(url_string), encoded))

-        print "Get_fb_stats got a key error 5 (%s) for url %s:" % (str(e), url % (urllib.quote_plus(url_string), encoded))

-        return shares, comments, likes

     if len(data) > 20:

         d = json.loads(data)['engagement']

         try:

@@ -600,7 +583,7 @@ if __name__=='__main__':

         # If any work was done, then write files.

         #

         if any_entry_added:

-            weekend_stats, weekday_stats = analysis.Process_feed(items, rhs_metric, rhs_metric_times)

+            weekend_stats, weekday_stats = analysis.process_feed(items, rhs_metric, rhs_metric_times)

             # We'll only look at the stats for the time 1:00 to 1:30 after posting.

             weekend_median, weekend_mean, weekend_sigma = weekend_stats[2]