techcrunch.git

@@ -108,9 +108,10 @@ def asciiize( s ):

     except exceptions.AttributeError, e:

         return s

+

 def sendEmail( subject, message, toaddrs, fromaddr='"techcrunch.py" <techcrunch@techcrunch.dlma.com>' ):

     """Sends Email"""

-    smtp = smtplib.SMTP( 'localhost' )

+    smtp = smtplib.SMTP( 'localhost', port=587 )

     smtp.login( user, passw )

     smtp.sendmail( fromaddr, \

                    toaddrs, \

@@ -254,8 +259,8 @@ def process_feed( yaml_items ):

                 if hasattr( feed, 'bozo_exception' ) and isinstance( feed.bozo_exception, xml.sax._exceptions.SAXParseException ):

                     print "Didn't pickle TechCrunch feed because it had a bozo_exception: %s" % ( str( feed.bozo_exception ) )

                 else:

-                    f = file( os.path.join( localdir, 'techcrunch_feed.pickle' ), 'wb' )

                     try:

+                        with open( os.path.join( localdir, 'techcrunch_feed.pickle' ), 'wb' ) as f:

                             pickle.dump( feed, f )

                     except( pickle.PicklingError, exceptions.TypeError ), e:

                         print "An error occurred while pickling the feed: %s." % \

@@ -263,7 +268,6 @@ def process_feed( yaml_items ):

                                 str(e) )

                         traceback.print_exc( 3, file = sys.stdout )

                         feed_is_modified = False

-                    f.close()

             for i in reversed( feed.entries ):

                 process_item( i, yaml_items )

@@ -490,7 +500,13 @@ def Get_num_disqus_comments( url_string, disqus_id, cookie ):

         print "Get_num_disqus_comments found no disqus tag for", url_string

     return -1

+

 def Get_num_retweets_unused( yaml_item ):

+    """ TODO: Support for retweents has been removed.

+    See: https://twittercommunity.com/t/a-new-design-for-tweet-and-follow-buttons/52791

+    So instead, use facebook.

+    curl https://graph.facebook.com/fql?q=SELECT%20total_count,comment_count,like_count,share_count%20FROM%20link_stat%20WHERE%20url=%27http://techcrunch.com/2015/11/22/the-real-reason-on-demand-startups-are-reclassifying-workers/?ncid=rss%27

+    """

     url_string = yaml_item['link']

     try:

         f = urllib2.urlopen( 'http://api.tweetmeme.com/button.js?url=%s' % ( url_string ) )

@@ -520,7 +536,13 @@ def Get_num_retweets_unused( yaml_item ):

                           )

     return -1

+

 def Get_num_retweets( yaml_item ):

+    """ TODO: Support for retweents has been removed.

+    See: https://twittercommunity.com/t/a-new-design-for-tweet-and-follow-buttons/52791

+    So instead, use facebook.

+    curl https://graph.facebook.com/fql?q=SELECT%20total_count,comment_count,like_count,share_count%20FROM%20link_stat%20WHERE%20url=%27http://techcrunch.com/2015/11/22/the-real-reason-on-demand-startups-are-reclassifying-workers/?ncid=rss%27

+    """

     url_string = yaml_item['link']

     try:

         f = urllib2.urlopen( 'http://urls.api.twitter.com/1/urls/count.json?url=%s&callback=twttr.receiveCount' % \

@@ -591,17 +614,16 @@ def Save_image( url_string, file_path ):

         f.close()

     except (urllib2.URLError, httplib.BadStatusLine), e:

         if hasattr( e, 'reason' ): # URLError

-            print "Save_image got an error attempting to create", file_path, "Reason:", e.reason

+            print "Save_image: Error attempting to create", file_path[file_path.rfind('/')+1:], "Reason:", e.reason

         elif hasattr( e, 'code' ): # URLError

-            print "Save_image got an error attempting to create", file_path, "Code:", e.code

+            print "Save_image: Error attempting to create", file_path[file_path.rfind('/')+1:], "Code:", e.code

         else:

-            print "Save_image got an error from urlopen", e

+            print "Save_image: Error from urlopen", e

         return url_string

     if len( data ) > 50:

-        f = open( file_path, 'wb' )

+        with open( file_path, 'wb' ) as f:

             f.write( data )

-        f.close()

         return 'cache/' + os.path.basename( file_path )

     return url_string

@@ -665,8 +688,9 @@ def Make_index_html( yaml_items, weekend_stats, weekday_stats ):

     for fname in files_to_delete:

         os.unlink( fname )

+

 def Make_feed_file( yaml_items ):

-    f = open( os.path.join( localdir, 'rss_feed.xml' ), 'wb' )

+    with open( os.path.join( localdir, 'rss_feed.xml' ), 'wb' ) as f:

         f.write( "<?xml version=\"1.0\" encoding=\"iso-8859-1\"?>\n<rss version=\"2.0\">\n<channel>\n<title>Trending at TechCrunch</title><link>http://techcrunch.dlma.com</link>" )

         f.write( "<pubDate>%s</pubDate><description>Automatically Generated Feed</description><language>en-us</language>\n" % ( time.strftime( "%a, %d %b %Y %H:%M:%S +0000", time.gmtime() ) ) )

         count = 0

@@ -681,7 +705,7 @@ def Make_feed_file( yaml_items ):

                 if count > 14:

                     break

         f.write( "</channel></rss>" )

-    f.close()

+

 if __name__=='__main__':

     start_time = time.time()

@@ -715,14 +739,13 @@ if __name__=='__main__':

         #

         yaml_fullpath = os.path.join( localdir, 'techcrunch.yaml' )

         if os.path.exists( yaml_fullpath ):

-            f = file( yaml_fullpath, 'rb' )

+            with open( yaml_fullpath, 'rb' ) as f:

                 items = yaml.load( f )

                 # Do any dictionary item updating that might be necessary

 #                for item in items:

 #                    if not item.has_key( 'fb_shares' ):

 #                        item['fb_shares'] = []

-            f.close()

         else:

             print "could not open", yaml_fullpath

             items = []

@@ -771,16 +794,16 @@ if __name__=='__main__':

             # For the one file we really use, write to a file on the side, then move it.

             yaml_newfile_fullpath = os.path.join( localdir, 'techcrunch_temp_writable.yaml' )

-            f = file( yaml_newfile_fullpath, 'wb' )

+            with open( yaml_newfile_fullpath, 'wb' ) as f:

                 yaml.dump( items, f, width=120 )

-            f.close()

+            try:

                 os.rename( yaml_newfile_fullpath, yaml_fullpath )

-            f = file( os.path.join( localdir, 'techcrunch_text.yaml' ), 'w' )

+            except OSError as e:

+                print "The source file was", yaml_newfile_fullpath, "and exists =", os.path.isfile(yaml_newfile_fullpath)

+            with open( os.path.join( localdir, 'techcrunch_text.yaml' ), 'w' ) as f:

                 yaml.dump( items, f, width=120 )

-            f.close()

-            f = codecs.open( os.path.join( localdir, 'techcrunch_unicode.yaml' ), 'w', 'utf-8' )

+            with codecs.open( os.path.join( localdir, 'techcrunch_unicode.yaml' ), 'w', 'utf-8' ) as f:

                 yaml.dump( items, f, encoding='utf-8', width=120 )

-            f.close()

             Make_feed_file( items )

@@ -807,17 +830,13 @@ if __name__=='__main__':

     # Finally, let's save this to a statistics page

     if os.path.exists( os.path.join( localdir, 'stats.txt' ) ):

-        f = open( os.path.join( localdir, 'stats.txt' ))

-        try:

+        with open( os.path.join( localdir, 'stats.txt' )) as f:

             lines = f.readlines()

-        finally:

-            f.close()

     else:

         lines = []

     lines = lines[:168] # Just keep the past week's worth

     # status = len( message.strip() ) and message.strip().replace( '\n', ' - ' ) or "OK"

     status = len( message.strip() ) and '\n                       '.join( message.splitlines() ) or "OK"

     lines.insert( 0, "%s %3.0fs %s\n" % ( time.strftime('%Y-%m-%d, %H:%M', time.localtime()), time.time() - start_time, status ))

-    f = open( os.path.join( localdir,'stats.txt' ), 'w' )

+    with open( os.path.join( localdir,'stats.txt' ), 'w' ) as f:

         f.writelines( lines )

-    f.close()